Tektronix AWG 70000 5028 resolution docstrings #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also make each dosctring a single line
Codecov Report
@@ Coverage Diff @@
## master #1628 +/- ##
=======================================
Coverage 70.55% 70.55%
=======================================
Files 123 123
Lines 14921 14921
=======================================
Hits 10527 10527
Misses 4394 4394 |
Codecov Report
@@ Coverage Diff @@
## master #1628 +/- ##
==========================================
- Coverage 70.55% 66.55% -4.01%
==========================================
Files 123 140 +17
Lines 14921 17389 +2468
==========================================
+ Hits 10528 11573 +1045
- Misses 4393 5816 +1423 |
astafan8
approved these changes
Jul 12, 2019
|
The coverage report reveals that this is not included in the coverage. Could you change .coverage to not exclude this driver (and possibly other Tektronix drivers that have tests)? |
|
Okay, let's see how much the coverage drops. |
|
I think we can land this with the coverage enabled for Tektronix |
giulioungaretti
pushed a commit
that referenced
this pull request
Jul 16, 2019
Merge: 65d176a 74f18ff Author: Jens Hedegaard Nielsen <[email protected]> Merge pull request #1628 from WilliamHPNielsen/driver/awg70000_resolution_docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1134
Changes proposed in this pull request:
@astafan8