Alazar: refactor AcquisitionInterface out of AcquisitionController
#1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1694 +/- ##
==========================================
+ Coverage 67.23% 67.25% +0.02%
==========================================
Files 145 145
Lines 17939 17949 +10
==========================================
+ Hits 12061 12072 +11
+ Misses 5878 5877 -1 |
astafan8
approved these changes
Sep 4, 2019
| super().__init__(name, **kwargs) | ||
| self._alazar = self.find_instrument(alazar_name, | ||
| instrument_class=AlazarTech_ATS) | ||
| def __init__(self, *args, **kwargs): |
There was a problem hiding this comment.
this is not needed, right?
There was a problem hiding this comment.
I think it might be, when using the interface as a mixin.
| @@ -889,38 +889,23 @@ class AcquisitionController(Instrument): | |||
| _alazar: a reference to the alazar instrument driver | |||
There was a problem hiding this comment.
should be removed as the interface doesn't have this attribute
There was a problem hiding this comment.
One should not document private attributes anyway
jenshnielsen
reviewed
Sep 5, 2019
jenshnielsen
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Alazar
AcquistionControlleris an interface for the alazar ats instrument, that takes care of handling the buffer data. In the current implementation this interface is a qcodes instrument.In my opinion this is an unnecessary coupling between pure number crunching code and qcodes instruments. I therefore suggest to refactor an
AcquisitionInterfaceout of theAcquisitionController, which only contains the interface methods.By letting the
AcquistionControllerinherit fromAcquistionInterfaceandInstrumentthe original functionality should stay untouched.Additionally I removed the
NotImplementedErrors from some of the methods, which don't need to be implemented.