Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-facing api docs: utils: plotting, slack, threading, validator, zmq_helpers #1725

Merged
merged 19 commits into from
Sep 30, 2019

Conversation

lakhotiaharshit
Copy link
Contributor

Corrects user-facing API docs in utils.

  • plotting
  • slack
  • threading
  • validator
  • zmq_helpers

@mention one core developer
@astafan8

@lakhotiaharshit lakhotiaharshit added the docs Related to docs improvements label Sep 18, 2019
Copy link
Collaborator

@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few small things

@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #1725 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1725      +/-   ##
==========================================
- Coverage   67.28%   67.28%   -0.01%     
==========================================
  Files         146      146              
  Lines       18138    18138              
==========================================
- Hits        12205    12204       -1     
- Misses       5933     5934       +1

@jenshnielsen
Copy link
Collaborator

jenshnielsen commented Sep 19, 2019

I fixed a bunch of other small issues:

  • Before Args: there should always be a blank line.
  • Args: is a special section -> So you should not have stuff like Inherited Args (see validators.Ints)
  • Context: should be in an Args section

A few more things that could be fixed

@jenshnielsen
Copy link
Collaborator

jenshnielsen commented Sep 19, 2019

Could you also add a short docstring at the top of the module for validators.py

This will be rendered here https://qcodes.github.io/Qcodes/api/utils/index.html on the right side of the table

@jenshnielsen
Copy link
Collaborator

Thanks this looks great

@jenshnielsen jenshnielsen merged commit baa1dc3 into microsoft:master Sep 30, 2019
@lakhotiaharshit lakhotiaharshit deleted the user_api_docw5 branch January 22, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to docs improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants