-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User-facing api docs: utils: plotting, slack, threading, validator, zmq_helpers #1725
User-facing api docs: utils: plotting, slack, threading, validator, zmq_helpers #1725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few small things
Codecov Report
@@ Coverage Diff @@
## master #1725 +/- ##
==========================================
- Coverage 67.28% 67.28% -0.01%
==========================================
Files 146 146
Lines 18138 18138
==========================================
- Hits 12205 12204 -1
- Misses 5933 5934 +1 |
I fixed a bunch of other small issues:
A few more things that could be fixed
|
Could you also add a short docstring at the top of the module for validators.py This will be rendered here https://qcodes.github.io/Qcodes/api/utils/index.html on the right side of the table |
Thanks this looks great |
Corrects user-facing API docs in utils.
@mention one core developer
@astafan8