fix get_shaped_data_by_runid #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated to reflect new return values from datatype_from_setpoints_2d()
Codecov Report
@@ Coverage Diff @@
## master #1735 +/- ##
==========================================
+ Coverage 67.27% 67.28% +0.01%
==========================================
Files 146 146
Lines 18138 18138
==========================================
+ Hits 12202 12204 +2
+ Misses 5936 5934 -2 |
jenshnielsen
approved these changes
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated to reflect new return values from datatype_from_setpoints_2d()
Fixes #1588
The function now returns ND arrays again, instead of giant 1D arrays.
Updates the function to expect new (renamed) return values from datatype_from_setpoints_2d() function.
grid renamed to 2D_grid, equidistant to 2D_equidistant
@jenshnielsen, @jana-d