-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that get_latest will call get on a parameter #1751
Merged
jenshnielsen
merged 16 commits into
microsoft:master
from
jenshnielsen:get_unknown_parameters
Oct 8, 2019
Merged
Ensure that get_latest will call get on a parameter #1751
jenshnielsen
merged 16 commits into
microsoft:master
from
jenshnielsen:get_unknown_parameters
Oct 8, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1751 +/- ##
==========================================
+ Coverage 67.5% 67.52% +0.02%
==========================================
Files 146 146
Lines 18320 18327 +7
==========================================
+ Hits 12366 12376 +10
+ Misses 5954 5951 -3 |
Todo
|
I uncovered a bug where max_val_age is never used in Parameter. Fixed and test added |
04d513f
to
476602f
Compare
jenshnielsen
commented
Oct 7, 2019
if the parameter has never been captured
parameter classes
620598f
to
93ccf36
Compare
@QCoDeS/core this is ready for review |
astafan8
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the parameter has never been captured it seems like
get_latest
should also callget
This is draft due to the missing tests