Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dataset shape when loading data with get_parameter_data and dataset cache #2264

Merged
merged 69 commits into from
Nov 10, 2020
Merged

Use dataset shape when loading data with get_parameter_data and dataset cache #2264

merged 69 commits into from
Nov 10, 2020

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Oct 9, 2020 •
edited
Loading

Incomple list of TODOS

  • Make sure that there are tests for the correct behaviour when shape do not match actual data. Including too much data captured and datasets that are stopped early.

@codecov
Copy link

codecov bot commented Oct 9, 2020 •
edited
Loading

Codecov Report

Merging #2264 (2dfbd67) into master (59af290) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2264      +/-   ##
==========================================
+ Coverage   62.21%   62.29%   +0.07%     
==========================================
  Files         200      200              
  Lines       26225    26275      +50     
==========================================
+ Hits        16316    16368      +52     
+ Misses       9909     9907       -2

@jenshnielsen jenshnielsen force-pushed the feature/dataset_shape_use_in_cache branch 11 times, most recently from 8b73458 to 7821a0f Compare October 23, 2020 08:03
@jenshnielsen jenshnielsen force-pushed the feature/dataset_shape_use_in_cache branch 4 times, most recently from 924660f to 7056ee0 Compare October 28, 2020 11:45
@jenshnielsen jenshnielsen mentioned this pull request Oct 28, 2020
Merged
@jenshnielsen jenshnielsen force-pushed the feature/dataset_shape_use_in_cache branch 10 times, most recently from 45d7abc to 5096b1a Compare November 3, 2020 07:20
@jenshnielsen jenshnielsen mentioned this pull request Nov 4, 2020
Merged
jenshnielsen and others added 27 commits November 10, 2020 09:59
@jenshnielsen
remote out of date todo
e7892ca
@jenshnielsen
improve test
35513ae
@jenshnielsen
handle if allocated cache is too small with a fall back
6315e6f
@jenshnielsen
test too small cache
9ffffe3
@jenshnielsen
set default for floats to nan
1aa627b
@jenshnielsen
break some too long lines
1fa55f9
@jenshnielsen
update docstring
85827fd
@jenshnielsen
remove duplicated test
a4a68bb
@jenshnielsen
also fill complex with nan
bfb8d07
@jenshnielsen
improve generation of string type setpoints
9cd705b
@jenshnielsen
add 1d shaped cache test
648031b 
This speficially adds a test with text setpoints
@jenshnielsen
handle that it may be needed to grow the datatype for strings
7e4b9c7
@jenshnielsen
disable deadline
c77c9bb
@jenshnielsen
fix generation of string setpoints for more than 25 points
9e55a35
@jenshnielsen @astafan8
Apply suggestions from code review
f20b7f8 
Co-authored-by: Mikhail Astafev <[email protected]>
@jenshnielsen
use description from dataset
2b42caf
@jenshnielsen
disable deadline
461cbf6
@jenshnielsen
only warn when there is more data than expected
3a635c0
@jenshnielsen
update docstrings
6843461
@jenshnielsen @astafan8
Update qcodes/tests/dataset/test_data_set_cache.py
a72ceee 
Co-authored-by: Mikhail Astafev <[email protected]>
@jenshnielsen
fix tests for log messages
9b67aad
@jenshnielsen
remove incorrect assertion
e280e74
@jenshnielsen
more explicit handling of insert
0915a0f
@jenshnielsen
explain the difference of get_parameter_data and cache.data
6b675b6
@jenshnielsen
test cache that is too large
2369277
@jenshnielsen
cleanup
9c22397
@jenshnielsen
better interlink
d7e7866
@jenshnielsen jenshnielsen force-pushed the feature/dataset_shape_use_in_cache branch from af07a18 to d7e7866 Compare November 10, 2020 08:59
@jenshnielsen jenshnielsen merged commit ee5e730 into microsoft:master Nov 10, 2020
@jenshnielsen jenshnielsen deleted the feature/dataset_shape_use_in_cache branch November 10, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jenshnielsen @astafan8