-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the full names when registering multiparameters #2317
Use the full names when registering multiparameters #2317
Conversation
5df12bc
to
17f8ff5
Compare
Codecov Report
@@ Coverage Diff @@
## master #2317 +/- ##
==========================================
- Coverage 61.87% 61.86% -0.01%
==========================================
Files 201 201
Lines 26122 26119 -3
==========================================
- Hits 16162 16159 -3
Misses 9960 9960 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@astafan8 Any suggestions for other ways of doing it?
no, becasue it think this IS the correct way of doing it.
Note This is a breaking change but I don't see any way around it.
me neither. i'd say this is a discovery of a bug, which is great.
Another way of fixing this PR could be to change __str__
to just return self.full_name
as opposed to the current implementation here https://github.com/QCoDeS/Qcodes/blob/master/qcodes/instrument/parameter.py#L387 . I actually think that changing __str__
must also be done regardless of this PR :)
The changes to not use |
that's fine, it's just that when reviewing i had to look and see what str(parameter) does to confirm the consistency ;) |
a5324af
to
9e92968
Compare
9e92968
to
01f7f54
Compare
For some reason multiparameters were unlike all other paramters not using the full name. This is both confusing and problematic if you have two multiparameters with the same short name (e.g. from different channels)
@astafan8 Any suggestions for other ways of doing it?
Note This is a breaking change but I don't see any way around it.