Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traceback of exception during measurement to dataset's metadata #2327

Merged
merged 7 commits into from
Oct 28, 2020

Conversation

astafan8
Copy link
Contributor

@astafan8 astafan8 commented Oct 22, 2020

The metadata key is called "exception".

questions/todos:

  • is the name of the metadata key good? - yes, "measurement_exception"
  • is storing a string good enough or shall we store the exception data in a more structured way? and if so, how? - string formatted by python's traceback module should be good enough for a start
  • add a test :) - done

@jenshnielsen
Copy link
Collaborator

Cool, this has some suggestions of how to serialize that may be useful https://stackoverflow.com/questions/45240549/how-to-serialize-an-exception/45241491

@jenshnielsen
Copy link
Collaborator

I don't have a better idea for the key name

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #2327 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2327      +/-   ##
==========================================
+ Coverage   62.12%   62.13%   +0.01%     
==========================================
  Files         200      200              
  Lines       26162    26164       +2     
==========================================
+ Hits        16252    16257       +5     
+ Misses       9910     9907       -3     

@astafan8 astafan8 requested a review from jenshnielsen October 28, 2020 11:58
@github-actions github-actions bot merged commit 8de7577 into master Oct 28, 2020
@jenshnielsen jenshnielsen deleted the astafan8-store-exception-in-dataset-metadata branch October 28, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants