-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full type checking of Qdac drivers #2341
Add full type checking of Qdac drivers #2341
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2341 +/- ##
=======================================
Coverage 62.32% 62.32%
=======================================
Files 200 200
Lines 26267 26276 +9
=======================================
+ Hits 16370 16377 +7
- Misses 9897 9899 +2 |
9fb2dd1
to
e2b860b
Compare
ba31620
to
0813f16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve as long as the change has been tested on the insturment (including the verbose mode :) )
I will test it with the instrument and approve it |
I tested this PR for Qdevil. It seems that it is working without any issue (tested instrument version is 1.07). For testing _assigned_triggers, the only requirement is to ramp_voltage for more than 1 channel, otherwise triggers is 1 and _assigned_triggers will not be populated. Then, setting slope to 'Inf' for each channel results in popping that channel out of the _assigned_triggers. @astafan8 |
@FarBo thanks for testing |
Perhaps @astafan8 meant |
update_currents=True queries the instrument for all channels and return responses, which can be seen as DEBUG messages in the load time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both Qdac and Qdevil tested with the instruments. I approve this PR, unless @astafan8 explicitly explains what he wants to be tested in verbose mode.
The verbose mode allows one to test this change (the square brackets got turned into curly brackets):
well, what can i say.... then no need to test the functionality that is not even supposed to be used by anyone apparently... :) |
Should be merged after #2336 and not backported. This probably should be tested manually on both devices