Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default terminator for Agilent E8527D #2434

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

mgunyho
Copy link
Contributor

@mgunyho mgunyho commented Nov 13, 2020

As a result of #2030, querying the value of the status parameter causes an exception, because without specifying the terminator, the query returns "1\n" or "0\n", which the val_mapping doesn't accept. This fixes that. Sorry for not testing this properly before.

@astafan8

@jenshnielsen jenshnielsen added this to the 0.20.0 milestone Nov 13, 2020
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #2434 (e92266b) into master (8973c8a) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #2434   +/-   ##
=======================================
  Coverage   62.36%   62.37%           
=======================================
  Files         200      200           
  Lines       26248    26248           
=======================================
+ Hits        16370    16371    +1     
+ Misses       9878     9877    -1     

@jenshnielsen jenshnielsen merged commit 6b96ac3 into microsoft:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants