Add explicit generics to most modules outside tests and drivers #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2453 +/- ##
=======================================
Coverage 62.31% 62.31%
=======================================
Files 200 200
Lines 26352 26352
=======================================
Hits 16422 16422
Misses 9930 9930 |
jenshnielsen
force-pushed
the
qcodes_no_implicit_generic_2
branch
from
1fd0361 to
e09d6db
Compare
astafan8
approved these changes
Nov 20, 2020
|
@astafan8 Actually constraining the types is a non goal of this pr. I will put your suggestions in another pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.