Add complete types to Validators #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
force-pushed
the
type_validators
branch
from
a787a88 to
75f09e7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2475 +/- ##
=======================================
Coverage 62.31% 62.31%
=======================================
Files 200 200
Lines 26356 26357 +1
=======================================
+ Hits 16423 16424 +1
Misses 9933 9933 |
astafan8
approved these changes
Nov 25, 2020
Co-authored-by: Mikhail Astafev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make this possible make the validator generic in the valid type which requires a few more modifications to typecheck nicely