Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wait time test #2935

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

jenshnielsen
Copy link
Collaborator

This test still causes random failures and I don't think it adds much if any value

this test will always be unreliable due to the way floating point math works and the limited persission of some cpu clocks
@jenshnielsen jenshnielsen force-pushed the remove_wait_time_test branch from 82b2e5e to 91fa00d Compare April 16, 2021 11:29
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #2935 (6e67974) into master (24b7258) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2935   +/-   ##
=======================================
  Coverage   65.30%   65.31%           
=======================================
  Files         208      208           
  Lines       28025    28031    +6     
=======================================
+ Hits        18302    18308    +6     
  Misses       9723     9723           

@jenshnielsen jenshnielsen enabled auto-merge April 16, 2021 12:45
@jenshnielsen jenshnielsen added this to the 0.25.0 milestone Apr 20, 2021
@jenshnielsen jenshnielsen merged commit 5772051 into microsoft:master Apr 20, 2021
@jenshnielsen jenshnielsen deleted the remove_wait_time_test branch October 25, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants