-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conversion between qcodes legacy DataSet and xarray format #2938
Add conversion between qcodes legacy DataSet and xarray format #2938
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2938 +/- ##
==========================================
+ Coverage 65.31% 65.41% +0.10%
==========================================
Files 209 209
Lines 28037 28122 +85
==========================================
+ Hits 18312 18397 +85
Misses 9725 9725 |
@peendebak Thanks, I will have a look. Happy to merge this to QCoDeS. I have edited the description to clarify that this is about the legacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peendebak thanks for the contribution (and the typing, and the tests)! if this helps for the users of the legacy DataSet, let's get it in :)
@astafan8 I addressed the comments, and added some more tests. The build seems to be failing due to a general error. |
@peendebak what do you mean with "general error"? the error here https://github.com/QCoDeS/Qcodes/pull/2938/checks?check_run_id=2399670141 seems to be a typo in the assert method call:
it should be assertEqual, with "t" :) |
Changes proposed in this pull request:
A minimal example:
@jenshnielsen The goal of this PR is to allow conversion between the easy cases (e.g. 1D, 2D). Since the two datasets have slightly different formats, we do not cover all cases. Can you comment on whether this functionality can be added to qcodes and if the structure of the PR is good?