Dataset protocol #3075
Merged
Dataset protocol #3075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
force-pushed
the
dataset_protocol
branch
from
c37be12 to
6af6e94
Compare
Codecov Report
@@ Coverage Diff @@
## master #3075 +/- ##
==========================================
+ Coverage 65.52% 65.55% +0.03%
==========================================
Files 215 216 +1
Lines 28509 28628 +119
==========================================
+ Hits 18681 18768 +87
- Misses 9828 9860 +32 |
jenshnielsen
force-pushed
the
dataset_protocol
branch
from
6af6e94 to
80fd00b
Compare
astafan8
reviewed
Jun 1, 2021
jenshnielsen
force-pushed
the
dataset_protocol
branch
from
e7129b8 to
18e0946
Compare
Co-authored-by: Mikhail Astafev <[email protected]>
this will follow in a new pr
jenshnielsen
force-pushed
the
dataset_protocol
branch
from
5389de8 to
5b7d2d9
Compare
astafan8
reviewed
Jun 3, 2021
astafan8
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define a protocol that datasets must implement to be able to act as a storage device for the measurement class:
Note that the protocol has no
__init__method as the arguments to the init method are currently very class specific