Use threaded setting from config in dond functions, and make process_params_meas public #3096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3096 +/- ##
=======================================
Coverage 65.65% 65.66%
=======================================
Files 216 216
Lines 28746 28748 +2
=======================================
+ Hits 18874 18876 +2
Misses 9872 9872 |
|
@ThorvaldLarsen I think this is how the cutoff_percentile was intended to be specified #3097 |
jenshnielsen
approved these changes
Jun 8, 2021
jenshnielsen
reviewed
Jun 8, 2021
This reverts commit 37e42d2.
astafan8
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a setting for use_threads in the config to be used in
process_params_measfor doNd functions. Allows control of the setting in the config file rather than a required input at runtime.Additionally makes the measure function public for external use of threaded parameter calls. This could be split out to a separate PR but included here in case there are no objections/concerns with this change.
Bug fix: moved dataset reference up in new dond to handle keyboardinterrupts similar to other functions in file.