Abstract parameter #3125
Merged
Abstract parameter #3125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
reviewed
Jun 15, 2021
There was a problem hiding this comment.
this looks neat and resembles how abc.ABC and abstractmethod work together in python! :) and it seems to me that this will still be supported by the new "static method of defining parameters" that folks are cooking in this PR #3098
Codecov Report
@@ Coverage Diff @@
## master #3125 +/- ##
==========================================
+ Coverage 65.64% 65.69% +0.05%
==========================================
Files 216 216
Lines 28784 28813 +29
==========================================
+ Hits 18896 18930 +34
+ Misses 9888 9883 -5 |
|
@jenshnielsen & @astafan8 Can you have another look at this, please? |
accidently added this
accidentally added this
accidentally added this
accidetally added this
jenshnielsen
approved these changes
Jun 28, 2021
added 3 commits
June 28, 2021 10:47
parameters 2) Add docstrings to the __post_init__ and __init_subclass__ methods 3) mypy ignore should be more specific.
This was referenced Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract parameters allow us to create abstract instrument types which are guaranteed to have certain parameters present. For instance, this will allow us to create a unified interface for all voltage sources.
Usually, when a parameter is added to an instrument and that instrument is sub classed and a parameter of the same name is added in the subclass as well, this will raise an exception. This issue is circumvented by specifying in the base class that the parameter being added there is of type AbstractParameter. The base class needs to be decorated with
abstract_instrument.A catch is that, if a unit is specified in the base class and a unit is specified in the sub class, these units must match.
@jenshnielsen, @astafan8