Fix numpy deprecation for ragged arrays #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3184 +/- ##
=======================================
Coverage 65.91% 65.92%
=======================================
Files 217 218 +1
Lines 28903 28910 +7
=======================================
+ Hits 19051 19058 +7
Misses 9852 9852 |
astafan8
approved these changes
Jul 7, 2021
|
Not a fan of utils but that is probably fine |
|
I don't think having a file called numpy.py is a good idea so I opted for numpy_utils.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract method from where this was already fixed and reuse it.
Perhaps we should think of another location for this method.