Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise if given more than one result for the same parameter name #3265

Merged

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Aug 16, 2021

This would have prevented a bug identified in #3186 where multiple values for the same result was passed to add_result.

It turns out that a number of tests relied on being able to pass in multiple parameters with setpoints that had been pre expanded and therefore multiple values for any shared setpoints. Technically this is an api break and should therefor probably be documented as such. I do not expect that many users would pre expand the setpoints so I am not that concerned about it.

This also revealed that one of the tests were buggy since it explicitly passes the same parameters multiple times (due to some code being commented out)

@trevormorgan could you take a look

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #3265 (f0fc25e) into master (2dc292b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3265   +/-   ##
=======================================
  Coverage   66.20%   66.20%           
=======================================
  Files         220      220           
  Lines       29246    29250    +4     
=======================================
+ Hits        19361    19365    +4     
  Misses       9885     9885           

@jenshnielsen jenshnielsen force-pushed the ensure_unique_parameter_names branch from bd152dd to 6dfa6f8 Compare August 24, 2021 10:57
@jenshnielsen
Copy link
Collaborator Author

@trevormorgan Ping

@trevormorgan trevormorgan added this to the 0.29.0 milestone Sep 2, 2021
@trevormorgan
Copy link
Contributor

@jenshnielsen changes look good to me.

@jenshnielsen jenshnielsen merged commit 84c2262 into microsoft:master Sep 2, 2021
@jenshnielsen jenshnielsen deleted the ensure_unique_parameter_names branch September 2, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants