Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post sweep actions to doND sweeps #3283

Merged
merged 9 commits into from
Aug 24, 2021

Conversation

FarBo
Copy link
Contributor

@FarBo FarBo commented Aug 20, 2021

This PR enables dond to take inner actions. The actions are passed in the Sweep instances.
The logic is as follows: actions for a sweep parameter will be called when the set value of that parameter is changed. I didn't put comments in the code, but I think it would be nice to add a few comments.

I couldn't find a a good way to unit test actions, so it is still missing if we want to have the test.

  • Update doNd notebook about the usage of actions in dond.

@jenshnielsen

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #3283 (1eea71f) into master (9249dd6) will increase coverage by 0.01%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #3283      +/-   ##
==========================================
+ Coverage   66.17%   66.19%   +0.01%     
==========================================
  Files         220      220              
  Lines       29216    29241      +25     
==========================================
+ Hits        19334    19356      +22     
- Misses       9882     9885       +3     

@jenshnielsen jenshnielsen changed the title Introducing inner actions in dond Add post sweep actions to doND sweeps Aug 24, 2021
@jenshnielsen jenshnielsen merged commit cbadccd into microsoft:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants