-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add register_name to register parameters by in datasets #5381
Merged
samantha-ho
merged 23 commits into
microsoft:master
from
samantha-ho:samanthaho/register_names
Oct 6, 2023
Merged
Add register_name to register parameters by in datasets #5381
samantha-ho
merged 23 commits into
microsoft:master
from
samantha-ho:samanthaho/register_names
Oct 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5381 +/- ##
=======================================
Coverage 68.30% 68.31%
=======================================
Files 341 341
Lines 29935 29946 +11
=======================================
+ Hits 20448 20458 +10
- Misses 9487 9488 +1 |
astafan8
reviewed
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
astafan8
approved these changes
Oct 6, 2023
for more information, see https://pre-commit.ci
…ha-ho/Qcodes into samanthaho/register_names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
register_name
property and kwarg to theParameterBase
class. This property defaults to returning the Parameterfull_name
.Additionally, this PR modifies the
register_parameter
andadd_result
methods in the Measurement context to use theregister_name
of the parameters rather than thefull_name
.These changes are made to split how parameters are organized within an Instrument or Station from how they show up in datasets. This allows greater flexibility on both ends. Attaching a Parameter to an instrument, for example, does not have to change the name of the parameter in the dataset.
These changes have been implemented for ParameterBase and registration has been updated for
ParameterWithSetpoints
.MultiParameter
andArrayParameter
setpoints registration has not been updated in this PR.To do: