-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve data collection performance and output #394
Open
arudell
wants to merge
29
commits into
main
Choose a base branch
from
support-multi-role
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to change-file-type-export-defaults
This was
linked to
issues
Feb 26, 2025
…to support-multi-role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes:
This pull request includes several changes to the
src/SdnDiagnostics.psm1
andsrc/SdnDiagnostics.psd1
files, focusing on enhancing the configuration state retrieval, data collection, and log management functionalities. The most important changes include adding new parameters, modifying existing functions to handle multiple roles, and improving log collection processes.Enhancements and new functionalities:
Get-SdnLogFile
to the module manifest filesrc/SdnDiagnostics.psd1
.Role
parameter to theSdnDiagnostics
configuration insrc/SdnDiagnostics.psm1
to define the current role(s) for the node.Improvements to configuration state retrieval:
Get-SdnConfigState
function to accept multiple roles and set theRole
parameter as optional, defaulting to the global configuration role. [1] [2]Enhancements to data collection:
Start-SdnDataCollection
function to handle multiple roles and nodes, including validation of WinRM connectivity and limiting data collection to a specified number of nodes per role. [1] [2] [3] [4]Change type
Checklist: