Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve data collection performance and output #394

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

arudell
Copy link
Member

@arudell arudell commented Feb 21, 2025

Description

Summary of changes:
This pull request includes several changes to the src/SdnDiagnostics.psm1 and src/SdnDiagnostics.psd1 files, focusing on enhancing the configuration state retrieval, data collection, and log management functionalities. The most important changes include adding new parameters, modifying existing functions to handle multiple roles, and improving log collection processes.

Enhancements and new functionalities:

  • Added a new cmdlet Get-SdnLogFile to the module manifest file src/SdnDiagnostics.psd1.
  • Introduced a new Role parameter to the SdnDiagnostics configuration in src/SdnDiagnostics.psm1 to define the current role(s) for the node.

Improvements to configuration state retrieval:

  • Modified the Get-SdnConfigState function to accept multiple roles and set the Role parameter as optional, defaulting to the global configuration role. [1] [2]

Enhancements to data collection:

  • Updated the Start-SdnDataCollection function to handle multiple roles and nodes, including validation of WinRM connectivity and limiting data collection to a specified number of nodes per role. [1] [2] [3] [4]
  • Improved the log collection process by separating the collection of diagnostic logs, event logs, and audit logs, and ensuring logs are collected from the appropriate nodes based on their roles. [1] [2] [3] [4]

Change type

  • Bug fix (non-breaking change)
  • Code style update (formatting, local variables)
  • New Feature (non-breaking change that adds new functionality without impacting existing)
  • Breaking change (fix or feature that may cause functionality impact)
  • Other

Checklist:

  • My code follows the style and contribution guidelines of this project.
  • I have tested and validated my code changes.

@arudell arudell marked this pull request as ready for review March 4, 2025 21:07
@arudell arudell requested a review from a team as a code owner March 4, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compress AuditLogs taken from hosts Speed up data collection as part of Start-SdnDataCollection
1 participant