Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lib.dom.d.ts to include Node.isConnected #22322

Closed
mlhaufe opened this issue Mar 4, 2018 · 1 comment
Closed

Update lib.dom.d.ts to include Node.isConnected #22322

mlhaufe opened this issue Mar 4, 2018 · 1 comment
Assignees
@mhegazy
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Milestone
TypeScript 2.8.3

Comments

@mlhaufe
Copy link

mlhaufe commented Mar 4, 2018 •
edited
Loading

The property isConnected is not defined in the Node interface:

https://github.com/Microsoft/TypeScript/blob/master/lib/lib.dom.d.ts#L8439

References:

https://developer.mozilla.org/en-US/docs/Web/API/Node/isConnected
https://dom.spec.whatwg.org/#dom-node-isconnected
@mhegazy mhegazy added Bug A bug in TypeScript Help Wanted You can do this Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript labels Mar 5, 2018
@mhegazy mhegazy added this to the Community milestone Mar 5, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Mar 5, 2018

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

@a-tarasyuk a-tarasyuk mentioned this issue Apr 1, 2018
Merged
@mhegazy mhegazy self-assigned this Apr 2, 2018
@mhegazy mhegazy added the Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet label Apr 2, 2018
@mhegazy mhegazy modified the milestones: Community, TypeScript 2.9 Apr 2, 2018
@mhegazy mhegazy mentioned this issue Apr 2, 2018
Merged
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Apr 2, 2018
@mhegazy mhegazy modified the milestones: TypeScript 2.9, TypeScript 2.8.2 Apr 2, 2018
@mhegazy mhegazy removed the Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet label Apr 2, 2018
javan added a commit to hotwired/stimulus that referenced this issue Jun 1, 2018
@javan
Bump TypeScript for Node.isConnected support
d3ea337 
microsoft/TypeScript#22322
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mhegazy mhegazy

Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Milestone
TypeScript 2.8.3
Development

No branches or pull requests
2 participants
@mlhaufe @mhegazy