jsconfig.json not respecting the exclude directory. #42797
Labels
Question
An issue which isn't directly actionable in code
Comments
|
Imported files are always included, and I would guess that you indirectly import the url module via React. You can try running the CLI with the |
|
Here's the initial output from |
RyanCavanaugh
added
the
Question
|
In 4.2+ you can also run |
|
This issue has been marked as 'Question' and has seen no recent activity. It has been automatically closed for house-keeping purposes. If you're still waiting on a response, questions are usually better suited to stackoverflow. |
|
I've run with And this is the output when pointing to a |
|
Please don't allow bots to auto-close an in-progress ticket. |
gurdiga
added a commit
to gurdiga/rss-email-subscription
that referenced
this issue
Jun 13, 2021
I started with jsconfig.json, but I stumbled upon a know issue [1] where tsc would throw typing errors from node_modules. I could work this around by adding @types/xml2js, which worked, but made no sense outside of the context of this tsc issue, so I opted for switching to tsconfig.json. [1]: microsoft/TypeScript#42797
|
This issue is closed but is still happening, even when the project has only a jsconfig.json file. I've refiled in #50862. |
|
This is a first result when searching, the solution is this:
Downside is that type inference doesn't work as well if you chuck that to jsconfig.json It's explained in the #50862 better, but solution is simply: add property to jsconfig.json {
"compilerOptions": {
"checkJs": true,
"strict": true,
"module": "CommonJS",
"resolveJsonModule": true,
"maxNodeModuleJsDepth": 0 // <--- ADD THIS
},Another solution is to call typechecking your project files like this: tsc -p jsconfig.json --maxNodeModuleJsDepth 0This way you can have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
🔎 Search Terms
jsconfig.json exclude
jsconfig.json node_modules
🕗 Version & Regression Information
tested typescript versions 4.0.0, 4.1.5, 4.3.0-dev.20210214
💻 Code
There's a sample repo here https://github.com/roebuk/jsconfig-issue
Clone, install dependencies, then run the two different npm scripts:
🙁 Actual behavior
Running
tsc -p jsconfig.jsonshould respect the"exclude": ["node_modules"]settings and not report errors withinnode_modules.🙂 Expected behavior
It should not report errors within node_modules, just like the running
tsc -p tsconfig.jsonThe text was updated successfully, but these errors were encountered: