Fix bug: normalize path after combining

[ghost]

Fixes #19113 (the one remaining bug as far as I can tell)
(Continuation of #21072)

[web-dave]

Is this fix in the released version? Face the issue: build is OK but vscode says error.

[ghost]

@web-dave It's possible that vscode is using a different TypeScript version than your build. Could you check that both are using typescript@next (in vscode it should tell you the TS version in the lower-right -- instructions here), and file a new issue if there is one?
EDIT: Actually, this PR won't affect a command-line build because it only affects completions.

[baflo]

@Andy-MS I'm running 2.7.1 in my workspace and with vscode. But I don't get code completion running as expected (it would work with app/... though):

[ghost]

@baflo I was able to get completions in 2.7.1 using:

tsconfig.json:

{
  "compilerOptions": {
    "baseUrl": "./src",
    "paths": {
      "@app/*": ["./app/*"]
    }
  }
}

src/a.ts: import {} from "@app"; (type a / after @app to get completions)

src/app/b.ts: export const x = 0;

Does this work for you? If so, could you try and get a simplified version of your situation that doesn't have the completions?

[baflo]

Hey @Andy-MS , I played a bit with your config. And I kind of get positive results. But not continuously.

Say I have your structure, but additionally a folder src/c with files src/c/c.ts and src/c/index.ts, then I can resolve b.ts but not files in src/c (only when I manually add the c/):

With the baseUrl setting it works well, however:

[ghost]

@baflo Thanks, looks like that was a bug that didn't show up in tests due to our test host differing from the real one.

[pie6k]

I've set VS Code ts version to 2.7 and I'm still having issue with paths not working properly

[ghost]

@pie6k Thanks, fixed in #21704