Fix ASI after get/set keyword #60225

rbuckton · 2024-10-14T21:00:10Z

jakebailey · 2024-10-14T22:11:23Z

typescript-bot · 2024-10-14T22:11:26Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-10-14T22:42:29Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-10-14T22:49:53Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60225/merge:

Everything looks good!

typescript-bot · 2024-10-14T22:52:35Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,618k (± 0.98%)}	_{195,887k (± 0.74%)}	_~	_192,920k	_196,500k	_{p=0.230 n=6}
_{Parse Time}	_{1.59s (± 1.69%)}	_{1.59s (± 1.36%)}	_~	_1.56s	_1.62s	_{p=0.744 n=6}
_{Bind Time}	_{0.87s (± 0.94%)}	_{0.87s (± 1.19%)}	_~	_0.85s	_0.88s	_{p=0.932 n=6}
_{Check Time}	_{11.72s (± 0.36%)}	_{11.73s (± 0.43%)}	_~	_11.66s	_11.81s	_{p=0.747 n=6}
_{Emit Time}	_{3.41s (± 4.33%)}	_{3.29s (± 0.71%)}	_~	_3.27s	_3.32s	_{p=0.085 n=6}
_{Total Time}	_{17.58s (± 0.71%)}	_{17.48s (± 0.33%)}	_~	_17.39s	_17.55s	_{p=0.173 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,886	_947,886	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,840	_410,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,832k (± 0.00%)}	_{1,224,800k (± 0.00%)}	_~	_1,224,744k	_1,224,905k	_{p=0.128 n=6}
_{Parse Time}	_{8.10s (± 0.46%)}	_{8.09s (± 0.72%)}	_~	_8.01s	_8.14s	_{p=1.000 n=6}
_{Bind Time}	_{2.27s (± 0.79%)}	_{2.27s (± 1.20%)}	_~	_2.24s	_2.31s	_{p=1.000 n=6}
_{Check Time}	_{37.91s (± 0.48%)}	_{37.83s (± 0.65%)}	_~	_37.64s	_38.17s	_{p=0.572 n=6}
_{Emit Time}	_{18.27s (± 0.46%)}	_{18.31s (± 0.44%)}	_~	_18.19s	_18.43s	_{p=0.470 n=6}
_{Total Time}	_{66.55s (± 0.32%)}	_{66.50s (± 0.27%)}	_~	_66.35s	_66.81s	_{p=0.573 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,530,075	_2,530,075	_~	_~	_~	_{p=1.000 n=6}
_Types	_916,374	_916,374	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,341,564k (± 0.00%)}	_{2,341,588k (± 0.00%)}	_~	_2,341,455k	_2,341,662k	_{p=0.810 n=6}
_{Parse Time}	_{11.24s (± 0.34%)}	_{11.21s (± 0.48%)}	_~	_11.14s	_11.28s	_{p=0.520 n=6}
_{Bind Time}	_{2.63s (± 0.65%)}	_{2.62s (± 1.12%)}	_~	_2.58s	_2.66s	_{p=0.870 n=6}
_{Check Time}	_{91.80s (± 1.43%)}	_{90.82s (± 0.59%)}	_~	_90.29s	_91.74s	_{p=0.127 n=6}
_{Emit Time}	_{0.35s (± 1.81%)}	_{0.35s (± 4.04%)}	_~	_0.33s	_0.37s	_{p=1.000 n=6}
_{Total Time}	_{106.02s (± 1.25%)}	_{105.01s (± 0.50%)}	_~	_104.48s	_105.88s	_{p=0.128 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,124	_1,258,125	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,266	_266,267	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,146,252k (± 0.02%)}	_{3,146,518k (± 0.02%)}	_~	_3,145,948k	_3,147,485k	_{p=0.689 n=6}
_{Parse Time}	_{6.61s (± 1.06%)}	_{6.59s (± 0.94%)}	_~	_6.52s	_6.70s	_{p=1.000 n=6}
_{Bind Time}	_{2.26s (± 4.21%)}	_{2.28s (± 5.57%)}	_~	_2.02s	_2.35s	_{p=0.376 n=6}
_{Check Time}	_{42.96s (± 0.52%)}	_{42.97s (± 0.21%)}	_~	_42.90s	_43.10s	_{p=0.575 n=6}
_{Emit Time}	_{3.53s (± 2.44%)}	_{3.48s (± 2.27%)}	_~	_3.38s	_3.56s	_{p=0.378 n=6}
_{Total Time}	_{55.37s (± 0.56%)}	_{55.31s (± 0.39%)}	_~	_55.03s	_55.56s	_{p=0.689 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,124	_1,258,125	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,266	_266,267	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,619,761k (±11.18%)}	_{2,619,332k (±11.19%)}	_~	_2,498,271k	_3,218,166k	_{p=0.810 n=6}
_{Parse Time}	_{6.55s (± 1.45%)}	_{6.62s (± 1.99%)}	_~	_6.54s	_6.88s	_{p=0.127 n=6}
_{Bind Time}	_{2.19s (± 4.03%)}	_{2.16s (± 1.93%)}	_~	_2.09s	_2.20s	_{p=1.000 n=6}
_{Check Time}	_{43.02s (± 0.32%)}	_{43.10s (± 0.46%)}	_~	_42.85s	_43.34s	_{p=0.423 n=6}
_{Emit Time}	_{3.50s (± 1.89%)}	_{3.54s (± 1.08%)}	_~	_3.47s	_3.58s	_{p=0.230 n=6}
_{Total Time}	_{55.28s (± 0.47%)}	_{55.40s (± 0.39%)}	_~	_55.08s	_55.62s	_{p=0.378 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,789	_261,790	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,508	_106,509	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{438,734k (± 0.01%)}	_{438,777k (± 0.02%)}	_~	_438,644k	_438,856k	_{p=0.575 n=6}
_{Parse Time}	_{4.40s (± 0.85%)}	_{4.40s (± 1.47%)}	_~	_4.32s	_4.47s	_{p=0.746 n=6}
_{Bind Time}	_{1.62s (± 0.91%)}	_{1.63s (± 1.14%)}	_~	_1.60s	_1.65s	_{p=0.463 n=6}
_{Check Time}	_{23.39s (± 0.47%)}	_{23.35s (± 0.16%)}	_~	_23.31s	_23.40s	_{p=0.809 n=6}
_{Emit Time}	_{1.91s (± 1.60%)}	_{1.92s (± 1.63%)}	_~	_1.87s	_1.96s	_{p=0.569 n=6}
_{Total Time}	_{31.31s (± 0.27%)}	_{31.29s (± 0.28%)}	_~	_31.17s	_31.36s	_{p=0.810 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,919	_225,919	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,415	_94,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,049k (± 0.01%)}	_{371,105k (± 0.01%)}	_~	_371,065k	_371,171k	_{p=0.065 n=6}
_{Parse Time}	_{3.60s (± 1.23%)}	_{3.62s (± 1.23%)}	_~	_3.57s	_3.69s	_{p=0.688 n=6}
_{Bind Time}	_{1.95s (± 0.90%)}	_{1.95s (± 1.57%)}	_~	_1.92s	_2.00s	_{p=0.870 n=6}
_{Check Time}	_{20.30s (± 0.55%)}	_{20.33s (± 0.40%)}	_~	_20.22s	_20.42s	_{p=0.873 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{25.86s (± 0.50%)}	_{25.90s (± 0.41%)}	_~	_25.79s	_26.04s	_{p=0.423 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,120,850	_3,120,850	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,075,428	_1,075,428	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,213,118k (± 0.01%)}	_{3,213,374k (± 0.01%)}	_~	_3,212,827k	_3,213,614k	_{p=0.230 n=6}
_{Parse Time}	_{14.07s (± 0.37%)}	_{14.10s (± 0.45%)}	_~	_14.04s	_14.18s	_{p=0.747 n=6}
_{Bind Time}	_{4.47s (± 2.22%)}	_{4.45s (± 0.63%)}	_~	_4.43s	_4.50s	_{p=0.870 n=6}
_{Check Time}	_{86.93s (± 1.35%)}	_{87.35s (± 3.15%)}	_~	_85.10s	_92.35s	_{p=0.936 n=6}
_{Emit Time}	_{26.29s (± 4.15%)}	_{23.59s (± 7.19%)}	_{🟩-2.70s (-10.27%)}	_22.66s	_26.95s	_{p=0.025 n=6}
_{Total Time}	_{131.76s (± 1.66%)}	_{129.48s (± 2.35%)}	_~	_126.40s	_133.69s	_{p=0.230 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_285,279	_285,279	_~	_~	_~	_{p=1.000 n=6}
_Types	_115,798	_115,798	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{435,603k (± 0.03%)}	_{435,677k (± 0.01%)}	_~	_435,598k	_435,745k	_{p=0.378 n=6}
_{Parse Time}	_{4.05s (± 1.60%)}	_{4.06s (± 0.83%)}	_~	_4.00s	_4.10s	_{p=0.520 n=6}
_{Bind Time}	_{1.75s (± 1.92%)}	_{1.76s (± 1.41%)}	_~	_1.73s	_1.80s	_{p=1.000 n=6}
_{Check Time}	_{18.40s (± 0.71%)}	_{18.43s (± 0.27%)}	_~	_18.35s	_18.48s	_{p=0.376 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.20s (± 0.46%)}	_{24.25s (± 0.28%)}	_~	_24.15s	_24.32s	_{p=0.196 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,222	_540,222	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,145	_181,145	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,811k (± 0.01%)}	_{483,833k (± 0.01%)}	_~	_483,773k	_483,939k	_{p=0.936 n=6}
_{Parse Time}	_{2.72s (± 0.30%)}	_{2.73s (± 0.38%)}	_~	_2.71s	_2.74s	_{p=0.437 n=6}
_{Bind Time}	_{0.97s (± 0.78%)}	_{0.97s (± 0.42%)}	_~	_0.96s	_0.97s	_{p=1.000 n=6}
_{Check Time}	_{15.95s (± 0.13%)}	_{16.00s (± 0.37%)}	_~	_15.93s	_16.09s	_{p=0.199 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.64s (± 0.10%)}	_{19.69s (± 0.31%)}	_~	_19.62s	_19.78s	_{p=0.226 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-10-15T00:12:07Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60225/merge:

Everything looks good!

Fix ASI after get/set keyword

185cb73

rbuckton requested review from sandersn and weswigham October 14, 2024 21:00

typescript-bot assigned rbuckton Oct 14, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Oct 14, 2024

jakebailey approved these changes Oct 14, 2024

View reviewed changes

rbuckton merged commit bd1641f into main Oct 16, 2024
32 checks passed

rbuckton deleted the fix59549 branch October 16, 2024 00:53

BrewTestBot mentioned this pull request Dec 20, 2024

esbuild 0.24.1 Homebrew/homebrew-core#201879

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix ASI after get/set keyword #60225

Fix ASI after get/set keyword #60225

rbuckton commented Oct 14, 2024

jakebailey commented Oct 14, 2024

typescript-bot commented Oct 14, 2024 •

edited

Loading

typescript-bot commented Oct 14, 2024

typescript-bot commented Oct 14, 2024

typescript-bot commented Oct 14, 2024

tsc

typescript-bot commented Oct 15, 2024

Fix ASI after get/set keyword #60225

Fix ASI after get/set keyword #60225

Conversation

rbuckton commented Oct 14, 2024

jakebailey commented Oct 14, 2024

typescript-bot commented Oct 14, 2024 • edited Loading

typescript-bot commented Oct 14, 2024

typescript-bot commented Oct 14, 2024

typescript-bot commented Oct 14, 2024

tsc

typescript-bot commented Oct 15, 2024

typescript-bot commented Oct 14, 2024 •

edited

Loading