Geolocation widget: fixing input number events #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| <!-- Copyright (c) Microsoft Corporation. All rights reserved. --> | |||
|
|
|||
| <!-- Include OpenLayers here rather than require'ing it, since it doesn't expose global variables when require'd --> | |||
| <!-- Include OpenLayers here rather than require"ing it, since it doesn"t expose global variables when require"d --> | |||
There was a problem hiding this comment.
Oops! wrong find and replace!
There was a problem hiding this comment.
Looks like some over-zealous find/replace happend here
|
Looks good to me. |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #103, which I've introduced when I updated from an input HTMLElement to cordova input web component.
Thanks!