Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure "step" attribute of all cordova-input-number used. #140

Merged
merged 2 commits into from
Aug 24, 2016

Conversation

albertinad
Copy link
Collaborator

Not all of the cordova-number-entry elements were configured properly according to the plugin API specification. This PR is to update the attribute configuration of cordova-number-entry, mostly for the geolocation widget.
This fix #117

- The default value is 1, but some of the usages requires a different
step.
@MSLaguana
Copy link
Member

Looks like we'll change from half unit steps to full unit on the orientation plugin, but it's still editable so I think that's fine.

Should we be imposing minimums on altitude? It is possible to be below sea level, such as at the dead sea.

Looks good in general.

@albertinad
Copy link
Collaborator Author

albertinad commented Aug 24, 2016

@MSLaguana I follow this documentation to set the min and step.

@TimBarham
Copy link

Altitude isn't spec'd as >= 0, is it? (seems negative numbers should be valid)

@TimBarham
Copy link

Not needed for this PR, but we should provide a way to specify null for values that support it.

@albertinad
Copy link
Collaborator Author

albertinad commented Aug 24, 2016

You're right @TimBarham, the spec doesn't specify anything in particular about the value that they can take, like the others. So, negative numbers seems supported too.
I've created an issue for addressing the update of cordova-plugin-geolocation simulation in order to support null and NaN values according to the spec: #141

Thanks!

@albertinad albertinad merged commit 9d4a35e into master Aug 24, 2016
@albertinad albertinad deleted the albertinad/input-step-config branch August 24, 2016 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cordova-number-entry fields indicate valid values are invalid
4 participants