Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HttpRequestException catch logic #18

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Add HttpRequestException catch logic #18

merged 1 commit into from
Mar 14, 2022

Conversation

Ben-Carpenter
Copy link
Contributor

Adding catch for HttpRequestException to allow retries here instead of by the consumer of the library.

@Ben-Carpenter Ben-Carpenter requested a review from a team March 14, 2022 20:31
@Ben-Carpenter Ben-Carpenter self-assigned this Mar 14, 2022
@Ben-Carpenter Ben-Carpenter linked an issue Mar 14, 2022 that may be closed by this pull request
Transient error not handled. HttpRequestException #17
Closed
@gt-downunder gt-downunder self-requested a review March 14, 2022 20:53
@Ben-Carpenter Ben-Carpenter merged commit 90a492c into main Mar 14, 2022
@Ben-Carpenter Ben-Carpenter deleted the hotfix/bc-add-HttpRequestException-catch branch March 14, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gt-downunder gt-downunder gt-downunder approved these changes

Assignees

@Ben-Carpenter Ben-Carpenter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transient error not handled. HttpRequestException
2 participants
@Ben-Carpenter @gt-downunder