add catch for GetInternalTesBlobUrlAsync

microsoft · jlester-msft · Feb 27, 2024 · Feb 28, 2024 · Feb 28, 2024 · Feb 28, 2024
commit 1712d1c9a284438689b3e2347f1b5b55b6d00fa2
diff --git a/src/TesApi.Web/Runner/TaskExecutionScriptingManager.cs b/src/TesApi.Web/Runner/TaskExecutionScriptingManager.cs
@@ -127,7 +127,15 @@
             logger.LogInformation($"Creating and uploading Batch script for Task ID: {tesTask.Id}");
 
             var nodeTaskRunnerUrl = await storageAccessProvider.GetInternalTesBlobUrlAsync(NodeTaskRunnerFilename, cancellationToken);
-            var nodeVMPerfArchiveUrl = await storageAccessProvider.GetInternalTesBlobUrlAsync(VMPerformanceArchiverFilename, cancellationToken);
+            Uri nodeVMPerfArchiveUrl;
+            try
+            {
+                nodeVMPerfArchiveUrl = await storageAccessProvider.GetInternalTesBlobUrlAsync(VMPerformanceArchiverFilename, cancellationToken);
+            }
+            catch (Exception e)
+            {
+                nodeVMPerfArchiveUrl = null;
+            }
 
             var batchNodeScript = batchNodeScriptBuilder
                 .WithAlpineWgetInstallation()

diff --git a/src/TesApi.Web/BatchNodeScriptBuilder.cs b/src/TesApi.Web/BatchNodeScriptBuilder.cs
        /// <param name="runnerTaskInfoUrl"></param>
        /// <param name="vmPerfArchiveUrl"></param>
        /// <returns></returns>
        public BatchNodeScriptBuilder WithRunnerFilesDownloadUsingWget(Uri runnerBinaryUrl, Uri runnerTaskInfoUrl, Uri? vmPerfArchiveUrl)
        {
            ArgumentNullException.ThrowIfNull(runnerBinaryUrl);
            ArgumentNullException.ThrowIfNull(runnerTaskInfoUrl);
	/// <param name="runnerTaskInfoUrl"></param>
	/// <param name="vmPerfArchiveUrl"></param>
	/// <returns></returns>
	public BatchNodeScriptBuilder WithRunnerFilesDownloadUsingWget(Uri runnerBinaryUrl, Uri runnerTaskInfoUrl, Uri? vmPerfArchiveUrl)
Check warning on line 87 in src/TesApi.Web/BatchNodeScriptBuilder.cs GitHub Actions / build `The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.` Check warning on line 87 in src/TesApi.Web/BatchNodeScriptBuilder.cs GitHub Actions / build `The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.` Check warning on line 87 in src/TesApi.Web/BatchNodeScriptBuilder.cs GitHub Actions / build `The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.` Check warning on line 87 in src/TesApi.Web/BatchNodeScriptBuilder.cs GitHub Actions / build `The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.`
	{
	ArgumentNullException.ThrowIfNull(runnerBinaryUrl);
	ArgumentNullException.ThrowIfNull(runnerTaskInfoUrl);