Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle sql.NullTime parameters #195

Merged
merged 3 commits into from
May 30, 2024

handle custom nullable Valuer implementations

fea1bfc
Select commit
Loading
Failed to load commit list.
Merged

Fix: handle sql.NullTime parameters #195

handle custom nullable Valuer implementations
fea1bfc
Select commit
Loading
Failed to load commit list.
Azure Pipelines / go-mssqldb Tests succeeded May 23, 2024 in 3m 3s

Build #20240523.1 had test failures

0 errors / 2 warnings

Details

Tests

  • Failed: 5 (5.62%)
  • Passed: 84 (94.38%)
  • Other: 0 (0.00%)
  • Total: 89
Code coverage

  • 1033 of 1452 lines covered (71.14%)

Annotations

Check failure on line 1 in TestAlwaysEncryptedE2E/AZURE_KEY_VAULT

See this annotation in the file changed.

@azure-pipelines azure-pipelines / go-mssqldb Tests

TestAlwaysEncryptedE2E/AZURE_KEY_VAULT 

Failed
Raw output 
=== RUN   TestAlwaysEncryptedE2E/AZURE_KEY_VAULT
    alwaysencrypted_test.go:95: 
        	Error Trace:	/home/vsts/work/1/s/alwaysencrypted_akv_test.go:29
        	            				/home/vsts/work/1/s/alwaysencrypted_test.go:95
        	Error:      	Received unexpected error:
        	            	DefaultAzureCredential authentication failed
        	            	POST https://login.microsoftonline.com/72f988bf-86f1-41af-91ab-2d7cd011db47/oauth2/v2.0/token
        	            	--------------------------------------------------------------------------------
        	            	RESPONSE 401 Unauthorized
        	            	--------------------------------------------------------------------------------
        	            	{
        	            	  "error": "invalid_client",
        	            	  "error_description": "AADSTS7000215: Invalid client secret provided. Ensure the secret being sent in the request is the client secret value, not the client secret ID, for a secret added to app '1024bf3a-2764-43cd-937e-01f89c02014b'. Trace ID: 8bfbff0a-c62b-4f47-9ae1-438d31250700 Correlation ID: dc87ccae-2f2a-491a-ac8e-6ded6afb04bd Timestamp: 2024-05-23 16:44:35Z",
        	            	  "error_codes": [
        	            	    7000215
        	            	  ],
        	            	  "timestamp": "2024-05-23 16:44:35Z",
        	            	  "trace_id": "8bfbff0a-c62b-4f47-9ae1-438d31250700",
        	            	  "correlation_id": "dc87ccae-2f2a-491a-ac8e-6ded6afb04bd",
        	            	  "error_uri": "https://login.microsoftonline.com/error?code=7000215"
        	            	}
        	            	--------------------------------------------------------------------------------
        	Test:       	TestAlwaysEncryptedE2E/AZURE_KEY_VAULT
        	Messages:   	CreateRSAKey
    tds_test.go:387: 2024-05-23 16:44:35.740429529 +0000 UTC m=+1.126833742 [tds.go:975]: Dialing with protocol tcp
    tds_test.go:387: 2024-05-23 16:44:35.741070934 +0000 UTC m=+1.127475047 [tds.go:987]: Returning connection from protocol tcp
    tds_test.go:387: 2024-05-23 16:44:35.749955401 +0000 UTC m=+1.136359514 [token.go:993]: got token tokenEnvChange
    tds_test.go:387: 2024-05-23 16:44:35.750023202 +0000 UTC m=+1.136427415 [token.go:993]: got token tokenInfo
    tds_test.go:387: 2024-05-23 16:44:35.750052802 +0000 UTC m=+1.136457015 [token.go:1122]: got INFO 5701 Changed database context to 'master'.
    tds_test.go:387: 2024-05-23 16:44:35.750068502 +0000 UTC m=+1.136472615 [token.go:1125]: Changed database context to 'master'.
    tds_test.go:387: 2024-05-23 16:44:35.750082502 +0000 UTC m=+1.136486615 [token.go:993]: got token tokenEnvChange
    tds_test.go:387: 2024-05-23 16:44:35.750095902 +0000 UTC m=+1.136500015 [token.go:993]: got token tokenEnvChange
    tds_test.go:387: 2024-05-23 16:44:35.750113002 +0000 UTC m=+1.136517115 [token.go:993]: got token tokenInfo
    tds_test.go:387: 2024-05-23 16:44:35.750125702 +0000 UTC m=+1.136529815 [token.go:1122]: got INFO 5703 Changed language setting to us_english.
    tds_test.go:387: 2024-05-23 16:44:35.750138102 +0000 UTC m=+1.136542215 [token.go:1125]: Changed language setting to us_english.
    tds_test.go:387: 2024-05-23 16:44:35.750150402 +0000 UTC m=+1.136554515 [token.go:993]: got token tokenLoginAck
    tds_test.go:387: 2024-05-23 16:44:35.750167803 +0000 UTC m=+1.136571916 [token.go:993]: got token tokenEnvChange
    tds_test.go:387: 2024-05-23 16:44:35.750182803 +0000 UTC m=+1.136586916 [token.go:993]: got token tokenFeatureExtAck
    tds_test.go:387: 2024-05-23 16:44:35.750195903 +0000 UTC m=+1.136600116 [token.go:993]: got token tokenDone
    tds_test.go:387: 2024-05-23 16:44:35.750207303 +0000 UTC m=+1.136611516 [token.go:1049]: got DONE or DONEPROC status=0
    tds_test.go:387: 2024-05-23 16:44:35.750250003 +0000 UTC m=+1.136654116 [mssql.go:528]: CREATE COLUMN MASTER KEY [https://sqltoolssecretstore.vault.azure.net/keys/go-mssqlkey153492] WITH (KEY_STORE_PROVIDER_NAME= 'AZ

Check failure on line 1 in TestAlwaysEncryptedE2E

See this annotation in the file changed.

@azure-pipelines azure-pipelines / go-mssqldb Tests

TestAlwaysEncryptedE2E 

Failed
Raw output 
=== RUN   TestAlwaysEncryptedE2E
--- FAIL: TestAlwaysEncryptedE2E (1.45s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0xa0 pc=0x8c31fa]

goroutine 27 [running]:
testing.tRunner.func1.2({0xa28260, 0x1014610})
	/opt/hostedtoolcache/go/1.20.0/x64/src/testing/testing.go:1526 +0x24e
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.20.0/x64/src/testing/testing.go:1529 +0x39f
panic({0xa28260, 0x1014610})
	/opt/hostedtoolcache/go/1.20.0/x64/src/runtime/panic.go:884 +0x213
github.com/microsoft/go-mssqldb/aecmk/akv.(*Provider).getKeyData(0xc0001898d0?, {0xbd0858, 0xc0000ba000}, {0xc0003a04b0, 0x42}, 0x1)
	/home/vsts/work/1/s/aecmk/akv/keyprovider.go:225 +0x2da
github.com/microsoft/go-mssqldb/aecmk/akv.(*Provider).EncryptColumnEncryptionKey(0x1?, {0xbd0858, 0xc0000ba000}, {0xc0003a04b0, 0x42}, {0xad2923, 0x8}, {0xc0004eeb40, 0x20, 0x20})
	/home/vsts/work/1/s/aecmk/akv/keyprovider.go:110 +0x6c
github.com/microsoft/go-mssqldb.TestAlwaysEncryptedE2E.func1(0xc0001529c0)
	/home/vsts/work/1/s/alwaysencrypted_test.go:110 +0x572
testing.tRunner(0xc0001529c0, 0xc000176bd0)
	/opt/hostedtoolcache/go/1.20.0/x64/src/testing/testing.go:1576 +0x10b
created by testing.(*T).Run
	/opt/hostedtoolcache/go/1.20.0/x64/src/testing/testing.go:1629 +0x3ea

Check failure on line 1 in TestAzureSqlAuth

See this annotation in the file changed.

@azure-pipelines azure-pipelines / go-mssqldb Tests

TestAzureSqlAuth 

Failed
Raw output 
=== RUN   TestAzureSqlAuth
    azuread_test.go:31: Unable to query the db: ClientSecretCredential authentication failed
        POST https://login.microsoftonline.com/72f988bf-86f1-41af-91ab-2d7cd011db47/oauth2/v2.0/token
        --------------------------------------------------------------------------------
        RESPONSE 401 Unauthorized
        --------------------------------------------------------------------------------
        {
          "error": "invalid_client",
          "error_description": "AADSTS7000215: Invalid client secret provided. Ensure the secret being sent in the request is the client secret value, not the client secret ID, for a secret added to app '1024bf3a-2764-43cd-937e-01f89c02014b'. Trace ID: a7529453-5b7b-4564-926d-efcac7ba6300 Correlation ID: bece7371-7435-4b58-aa3b-9552ce0f5c0e Timestamp: 2024-05-23 16:44:38Z",
          "error_codes": [
            7000215
          ],
          "timestamp": "2024-05-23 16:44:38Z",
          "trace_id": "a7529453-5b7b-4564-926d-efcac7ba6300",
          "correlation_id": "bece7371-7435-4b58-aa3b-9552ce0f5c0e",
          "error_uri": "https://login.microsoftonline.com/error?code=7000215"
        }
        --------------------------------------------------------------------------------
        To troubleshoot, visit https://aka.ms/azsdk/go/identity/troubleshoot#client-secret
--- FAIL: TestAzureSqlAuth (1.31s)

Check failure on line 1 in TestEncryptDecryptRoundTrip

See this annotation in the file changed.

@azure-pipelines azure-pipelines / go-mssqldb Tests

TestEncryptDecryptRoundTrip 

Failed
Raw output 
=== RUN   TestEncryptDecryptRoundTrip
    keyprovider_test.go:23: 
        	Error Trace:	/home/vsts/work/1/s/aecmk/akv/keyprovider_test.go:23
        	Error:      	Received unexpected error:
        	            	DefaultAzureCredential authentication failed
        	            	POST https://login.microsoftonline.com/72f988bf-86f1-41af-91ab-2d7cd011db47/oauth2/v2.0/token
        	            	--------------------------------------------------------------------------------
        	            	RESPONSE 401 Unauthorized
        	            	--------------------------------------------------------------------------------
        	            	{
        	            	  "error": "invalid_client",
        	            	  "error_description": "AADSTS7000215: Invalid client secret provided. Ensure the secret being sent in the request is the client secret value, not the client secret ID, for a secret added to app '1024bf3a-2764-43cd-937e-01f89c02014b'. Trace ID: ebbbbefa-6deb-484a-9334-6a6072815c00 Correlation ID: f6c5d54d-91af-43d2-8c2a-36af898932bc Timestamp: 2024-05-23 16:44:36Z",
        	            	  "error_codes": [
        	            	    7000215
        	            	  ],
        	            	  "timestamp": "2024-05-23 16:44:36Z",
        	            	  "trace_id": "ebbbbefa-6deb-484a-9334-6a6072815c00",
        	            	  "correlation_id": "f6c5d54d-91af-43d2-8c2a-36af898932bc",
        	            	  "error_uri": "https://login.microsoftonline.com/error?code=7000215"
        	            	}
        	            	--------------------------------------------------------------------------------
        	Test:       	TestEncryptDecryptRoundTrip
        	Messages:   	CreateRSAKey
    keyprovider_test.go:29: Plainkey: [238 159 45 167 148 139 129 232 60 105 112 85 107 250 112 140 55 135 139 174 34 74 143 74 50 246 119 177 63 133 72 175]
--- FAIL: TestEncryptDecryptRoundTrip (1.54s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0xa0 pc=0x8aa600]

goroutine 4 [running]:
testing.tRunner.func1.2({0x912ac0, 0xd6c660})
	/opt/hostedtoolcache/go/1.20.0/x64/src/testing/testing.go:1526 +0x24e
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.20.0/x64/src/testing/testing.go:1529 +0x39f
panic({0x912ac0, 0xd6c660})
	/opt/hostedtoolcache/go/1.20.0/x64/src/runtime/panic.go:884 +0x213
github.com/microsoft/go-mssqldb/aecmk/akv.(*Provider).getKeyData(0x98c460?, {0xa6a2b8, 0xc000034190}, {0xc0000aacc0, 0x42}, 0x1)
	/home/vsts/work/1/s/aecmk/akv/keyprovider.go:225 +0x320
github.com/microsoft/go-mssqldb/aecmk/akv.(*Provider).EncryptColumnEncryptionKey(0x1?, {0xa6a2b8, 0xc000034190}, {0xc0000aacc0, 0x42}, {0x9a199c, 0x8}, {0xc000478e40, 0x20, 0x20})
	/home/vsts/work/1/s/aecmk/akv/keyprovider.go:110 +0x92
github.com/microsoft/go-mssqldb/aecmk/akv.TestEncryptDecryptRoundTrip(0xc00016e9c0)
	/home/vsts/work/1/s/aecmk/akv/keyprovider_test.go:30 +0x2b7
testing.tRunner(0xc00016e9c0, 0x9e12b0)
	/opt/hostedtoolcache/go/1.20.0/x64/src/testing/testing.go:1576 +0x10b
created by testing.(*T).Run
	/opt/hostedtoolcache/go/1.20.0/x64/src/testing/testing.go:1629 +0x3ea
View more details on Azure Pipelines