Move optimized ucs22str function to 64bit only #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the -race parameter needs to become part of the matrix in the yml In reply to: 1057622190 |
Codecov Report
@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 72.03% 72.56% +0.53%
==========================================
Files 23 25 +2
Lines 5604 5596 -8
==========================================
+ Hits 4037 4061 +24
+ Misses 1319 1297 -22
+ Partials 248 238 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. |
apoorvdeshmukh
approved these changes
Aug 4, 2022
|
Why? |
Because the original PR author who wrote the optimized function didn't build or test it for 32bit and it was just our quickest option to unblock 32bit consumers. I'm open to someone revisiting the optimized function to make it 32bit compatible. |
ondrejsika
added a commit
to ondrejsika/fork-go-mssqldb-32bit-for-slu
that referenced
this pull request
Feb 3, 2023
This reverts commit 63479d5.
ondrejsika
added a commit
to ondrejsika/fork-go-mssqldb-32bit-for-slu
that referenced
this pull request
Feb 3, 2023
This reverts commit 63479d5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39
I also moved some test code to 64bit-only as it either doesn't compile for 32bit or fails during the test run. We aren't going to spend much time debugging such failures since they are longstanding at this point. I added a 32bit test run to the appveyor build to help prevent future 32bit breaks.