Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderWhitespace defaults to "selection", not "none" #2502

Closed
richardtallent opened this issue May 25, 2021 · 5 comments
Closed

renderWhitespace defaults to "selection", not "none" #2502

richardtallent opened this issue May 25, 2021 · 5 comments
Assignees
Labels
help wanted Issues identified as good community contribution opportunities
Milestone

Comments

@richardtallent
Copy link

The documentation says that renderWhitespace defaults to none.

However, I noticed in my code that it is defaulting to selection. I confirmed this by opening an empty playground and selecting some text. Setting this option to none manually resulted in the expected behavior.

monaco-editor version: 0.24.0
Browser: Chrome (latest)
OS: Windows 10
Playground code that reproduces the issue: https://microsoft.github.io/monaco-editor/playground.html

@hediet
Copy link
Member

hediet commented Jun 4, 2021

Nice catch and thanks for reporting! Feel free to do a PR on the VS Code repository that fixes the documentation! I'll help you to get it merged.

@hediet hediet added this to the On Deck milestone Jun 4, 2021
@hediet hediet added the help wanted Issues identified as good community contribution opportunities label Jun 4, 2021
@hediet hediet self-assigned this Jun 4, 2021
@richardtallent
Copy link
Author

Thanks @hediet, I'd be happy to!

I would have already, but I can't actually find the repository that houses the docs. It's not listed in the contribution guidelines, doesn't appear to be in this repo, and I struck out searching for it:

https://github.com/microsoft/monaco-editor/blob/main/CONTRIBUTING.md
https://github.com/microsoft?q=monaco&type=&language=&sort=

Here's where it appears in the docs, but there's also no GitHub link there:

https://microsoft.github.io/monaco-editor/api/interfaces/monaco.editor.ieditoroptions.html#renderwhitespace

@hediet
Copy link
Member

hediet commented Jun 5, 2021

Awesome! This repo does not contain the actual source code, it is all in the VS Code repo (the contribution guidelines should say so, if not, we need to update that).

I guess you mean the JS Doc? I think the source for it is here.

@richardtallent
Copy link
Author

Thanks! That makes more sense now. I saw that file, but thought it was auto-generated from something else. Always a challenge to find one's way around a massive codebase for the first PR! :)

@hediet
Copy link
Member

hediet commented Jun 5, 2021

Understandably. Feel free to ping me in your PR against the VS Code repository!

@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

No branches or pull requests

2 participants