Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to build for PHP8.0 #1167

Closed
wants to merge 1 commit into from
Closed

Conversation

mmokhi
Copy link

@mmokhi mmokhi commented Jul 27, 2020

There are some major internal changes coming with PHP8.0 and causing some internal API changes and Macros being deprecated.
This ensures these cases are being taken care of.
More info:
https://github.com/php/php-src/blob/php-8.0.0alpha3/UPGRADING.INTERNALS#L47

There are some major internal changes coming with PHP8.0 and causing some internal API changes and Macros being deprecated.
This ensures these cases are being taken care of.
More info:
https://github.com/php/php-src/blob/php-8.0.0alpha3/UPGRADING.INTERNALS#L47
@mmokhi mmokhi mentioned this pull request Jul 27, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 74.401% when pulling 952d02d on mmokhi:patch-1 into 5f76f83 on microsoft:master.

@yitam
Copy link
Contributor

yitam commented Jul 27, 2020

Thank you @mmokhi for your contribution! As I already explained, #1127 has taken care of this. Next time please submit pull requests to our dev branch, which should compile with php 8.0 alpha.

@yitam
Copy link
Contributor

yitam commented Jul 28, 2020

Closing this now, @mmokhi

@yitam yitam closed this Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants