Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IpmiSetSensorThreshold and IpmiGetSensorThreshold in the MockIpmiCommandLib #277

Merged

Conversation

SeolforHsieh
Copy link
Contributor

@SeolforHsieh SeolforHsieh commented Feb 13, 2025

Add IpmiSetSensorThreshold and IpmiGetSensorThreshold in the MockIpmiCommandLib

Description

Add IpmiSetSensorThreshold and IpmiGetSensorThreshold in the MockIpmiCommandLib

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Unit tests component can call these mock functions success

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Feb 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.92%. Comparing base (15f1253) to head (50d9ad2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   27.92%   27.92%           
=======================================
  Files          41       41           
  Lines        3019     3019           
  Branches      404      404           
=======================================
  Hits          843      843           
  Misses       2164     2164           
  Partials       12       12           
Flag Coverage Δ
IpmiFeaturePkg 27.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SeolforHsieh
Copy link
Contributor Author

@apop5 and @VivianNK for vis.

@apop5 apop5 requested a review from VivianNK February 14, 2025 03:56
@SeolforHsieh
Copy link
Contributor Author

@VivianNK,
please review this PR.

@VivianNK VivianNK force-pushed the user/seolfor/mockIpmiSensorThreshold branch from facc468 to 50d9ad2 Compare February 18, 2025 19:15
@apop5 apop5 merged commit c3c2c37 into microsoft:main Feb 19, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants