Supports KCS command register declare #286
Open
+28
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KCS data and command registers may be decode "discontinuous", so a new PCD is added to manage the command register. For example: IO 62h/66h as KCS data and command registers.
github-actions
bot
added
the
impact:non-functional
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
==========================================
+ Coverage 27.92% 28.07% +0.14%
==========================================
Files 41 41
Lines 3019 3003 -16
Branches 404 404
==========================================
Hits 843 843
+ Misses 2164 2148 -16
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bmc ACPI supports being decoded as a "discontinuous" case. Removed the dynamic update IO decode in the BmcAcpi DXE driver. The new way is FixedAtBuild PCD filled in the ASL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
KCS data and command registers may be decoded as "discontinuous," so a new PCD is added to manage the command register.
For example:
IO 62h/66h as KCS data and command registers.
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
This modification does not affect the original operation.
If the system declares CA2h/CA3h, make sure the IPMI KCS works as expected.
Integration Instructions
If your system KCS data and command registers may be decoded as "discontinuous," please refer this:
Example:
IO 62h/66h as KCS data and command registers.
The IPMI device:
Original
Modification