feat: support TestProject.workers limit #35094
Merged
+222
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
reviewed
Mar 7, 2025
This comment has been minimized.
This comment has been minimized.
pavelfeldman
reviewed
Mar 7, 2025
| for (const project of config.projects) { | ||
| if (project.workers) | ||
| this._workerLimitPerProjectId.set(project.id, project.workers); | ||
| } | ||
| } | ||
|
|
||
| private async _scheduleJob() { |
There was a problem hiding this comment.
Let's make sure this is not async to reason about stable order.
pavelfeldman
approved these changes
Mar 7, 2025
dgozman
force-pushed
the
tr-project-workers
branch
from
bfa7ee7 to
2b6b380
Compare
Test results for "tests 1"1 failed 4 flaky38675 passed, 803 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21970.