chore: fix internal tool usage #35156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
yury-s
approved these changes
Mar 12, 2025
| @@ -66,12 +66,13 @@ export class Server { | |||
| } | |||
|
|
|||
| private async _createBrowser(): Promise<playwright.Browser> { | |||
| const headless = process.env.PLAYWRIGHT_HEADLESS === '1' || process.env.PLAYWRIGHT_HEADLESS === 'true'; | |||
There was a problem hiding this comment.
for demo purposes for now
| const elementProperties = { | ||
| element: { | ||
| type: 'string', | ||
| description: 'Element label, description of any other text to describe the element', |
There was a problem hiding this comment.
Suggested change
| description: 'Element label, description of any other text to describe the element', | |
| description: 'Element label, description or any other text to describe the element', |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Yury Semikhatsky <[email protected]> Signed-off-by: Pavel Feldman <[email protected]>
Test results for "tests 1"1 failed 6 flaky38708 passed, 807 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.