Add problem matchers for RuboCop and minitest #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tido64
force-pushed
the
tido/ruby-matchers
branch
4 times, most recently
from
32d5e51 to
39aad40
Compare
tido64
force-pushed
the
tido/ruby-matchers
branch
3 times, most recently
from
8d11bb9 to
1d76fb4
Compare
tido64
commented
Apr 9, 2020
| { | ||
| "regexp": "^\\s*((?:Expected|Actual).*)$", | ||
| "message": 1, | ||
| "loop": true |
There was a problem hiding this comment.
Due to a limitation in the format of problem matchers, it's currently not possible to extract multiline messages. For input such as:
TestTestApp#test_resources_pod_returns_spec_path [test/test_test_app.rb:31]:
Expected: ".."
Actual: "."
"Expected: …" and "Actual: …" are two separate errors with this matcher. We are currently not able to match output such as:
TestTestApp#test_resources_pod_writes_podspec [test/test_test_app.rb:50]:
--- expected
+++ actual
@@ -1 +1 @@
-["dist/assetd", "dist/main.jsbundle"]
+["dist/assets", "dist/main.jsbundle"]
This issue has been reported in actions/toolkit#193 and actions/toolkit#319.
|
Example output: |
|
Should we add a rule to require RuboCop / ESLint checks to pass before merging PRs? |
arazabishov
approved these changes
Apr 9, 2020
Yeah, I can make them required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.