Skip to content

Commit

Permalink
eng - turn SHA mismatch into warning to unblock windows (#16)
Browse files Browse the repository at this point in the history
  • Loading branch information
bpasero authored Sep 10, 2024
1 parent 759e211 commit f1034a5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@vscode/vscode-bisect",
"version": "0.4.9",
"version": "0.4.10",
"description": "Bisect released VS Code Insider builds to find bugs or performance issues similar to what git bisect supports.",
"repository": {
"type": "git",
Expand Down
6 changes: 2 additions & 4 deletions src/builds.ts
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,9 @@ class Builds {
const expectedSHA256 = (await this.fetchBuildMeta({ runtime, commit })).sha256hash;
const computedSHA256 = await computeSHA256(path);
if (expectedSHA256 !== computedSHA256) {
throw new Error(`SHA256 hash of downloaded file does not match the expected hash. Expected: ${expectedSHA256}, Got: ${computedSHA256}`);
console.log(`${chalk.gray('[build]')} expected SHA256 checksum (${expectedSHA256}) does not match with download (${computedSHA256}) ${chalk.red('✘')}`);
} else {
if (LOGGER.verbose) {
console.log(`${chalk.gray('[build]')} expected SHA256 checksum matches with download ${chalk.green('✔︎')}`);
}
console.log(`${chalk.gray('[build]')} expected SHA256 checksum matches with download ${chalk.green('✔︎')}`);
}

// Unzip
Expand Down

0 comments on commit f1034a5

Please sign in to comment.