Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code Highlighting keywords incorrectly after update #3420

Closed
ThadHouse opened this issue Apr 5, 2019 · 4 comments
Closed

VS Code Highlighting keywords incorrectly after update #3420

ThadHouse opened this issue Apr 5, 2019 · 4 comments

Comments

@ThadHouse
Copy link

This issue is actually, caused by the VS Code 1.33 update, but I'm posting it here as it might get greater visability by someone who knows C++ rather. Since updating to 1.33, code highlighting for C++ specifically has gotten much work. The biggest one is I have a typedef COMM_Bool, and the Bool part actually gets highlighted differently then the COMM_ part. In addition, some local variables are randomly now blue rather then white, but not all. It's very distracting. I've attached pics of these issues, older version on top, newer version on bottom.

Old

BoolOld
BlueOldWakeup

New

CppBool
BlueNewWakeup

I can move this issue to VS Code if you would like, but I think it will get lost there.

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Apr 5, 2019

VS Code switched to using the colorization parser from https://github.com/jeff-hykin/cpp-textmate-grammar/issues . Can you file a bug with that extension? Or I could file the bug for you. Fixes to that extension will get picked up by VS Code over time (not sure how often).

@ThadHouse
Copy link
Author

I'll try and post an issue there, and I'm going to put an issue on vscode as well. The new parser is horrible, and it should be reverted. After playing with is for a day, I've probably found 10 more things that are very bad and make the experience much worse.

@ThadHouse
Copy link
Author

jeff-hykin/better-cpp-syntax#58
jeff-hykin/better-cpp-syntax#59
jeff-hykin/better-cpp-syntax#60

I created issues for the 3 major things I found, and will create more when I find them.

@ThadHouse
Copy link
Author

I was able to use the extension from that repo to override the built in vscode default, and a newer version already had 2 of the 3 things fixed.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants