Skip to content
This repository was archived by the owner on Nov 30, 2023. It is now read-only.

Update the R definition according to the extension update #1007

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Aug 21, 2021

Reflects the extension and the base image updates, and makes improvements that weren't in time for the last PR #954.

  1. Since the settings vsc.use_httpgd = TRUE made on Rprofile can now be done from settings.json too, delete it from the Dockerfile and move it to devcontainer.json. (Accessing VS Code settings in R REditorSupport/vscode-R#743)
  2. Change the VALIANT and comments which select a R version to match other definitions as the base image now pushes minor and major version tags. (Update for automated multi-tagging and reducing the number of stack files rocker-org/rocker-versioned2#214)
  3. Add a new extension rdebugger.r-debugger that enable debugging of R on VS Code and the R package vscDebugger required by rdebugger.r-debugger. (Suggested by Update the R definition #954 (comment))
  4. Update the test-project to resemble other definitions.
    However, I didn't add launch.json because I thought that execution using launch.json would be done on the internal console and may confuse the user. (Add "console" option to open itegrated terminal instead of internal console ManuelHentschel/VSCode-R-Debugger#147)

cc @kmehant @renkun-ken @ManuelHentschel @ElianHugh

@eitsupi eitsupi changed the title Update R definition according to the extension update Update the R definition according to the extension update Aug 21, 2021
@Chuxel
Copy link
Member

Chuxel commented Aug 26, 2021

LGTM! Thanks for the contribution!!

@Chuxel Chuxel merged commit 0744476 into microsoft:main Aug 26, 2021
@eitsupi eitsupi deleted the update-r branch August 26, 2021 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants