Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 114923 - HTML figcaption tag should be suggested when using the full word #44

Merged
merged 7 commits into from
Feb 12, 2021

Conversation

AnuBhar
Copy link
Contributor

@AnuBhar AnuBhar commented Feb 5, 2021

Fix for Issue - HTML figcaption tag should be suggested when using the full word instead of only "figc"
Screenshot (2)

@AnuBhar AnuBhar marked this pull request as ready for review February 5, 2021 20:23
@rzhao271
Copy link
Contributor

rzhao271 commented Feb 8, 2021

Thanks! Can you add a unit test for this case in expand.ts?

@rzhao271
Copy link
Contributor

rzhao271 commented Feb 8, 2021

Fixes microsoft/vscode#114923.

@ghost
Copy link

ghost commented Feb 11, 2021

CLA assistant check
All CLA requirements met.

@rzhao271
Copy link
Contributor

rzhao271 commented Feb 11, 2021

I just checked and realized your new unit test fails. I'll leave it as an exercise for you to fix the test (hint: the expected output should have a $ in it).
The easiest way to test the repository is to open it in VS Code, open the integrated terminal, and run yarn; yarn compile; yarn test. You'll also want to install yarn on your device if you don't have it yet.

@rzhao271 rzhao271 merged commit a65ff8f into microsoft:main Feb 12, 2021
@rzhao271
Copy link
Contributor

Thanks again! 🎉

@rzhao271 rzhao271 added this to the February 2021 milestone Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants