Added E2E execution plan tests with coverage #18929
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurennat
requested review from
kburtram,
aasimkhan30,
cssuh,
caohai,
lewis-sanchez and
Benjin
as code owners
PR Changes
|
Are you planning to add these tests to the CI pipeline in a seperate PR? |
|
Yes, I'm adding it in later |
aasimkhan30
reviewed
Mar 14, 2025
| } | ||
|
|
||
| export async function tabToQueryPlanToolbar(vsCodePage: Page): Promise<void> { | ||
| // Go to query plan toolbar from main state |
There was a problem hiding this comment.
I don't know if this will be scalable. Should we think about creating mock vscode socket and run these the webview panels in the browser? I think we were doing something similar for Fabric.
aasimkhan30
reviewed
Mar 14, 2025
| vsCodePage, | ||
| "Actual Number of Rows For All Executions", | ||
| ); | ||
| await checkScreenshot( |
There was a problem hiding this comment.
What does check screenshot functionality do exactly? Since we cannot access contents on the page, how will we check if our key downs are having intended effect?
caohai
reviewed
Mar 14, 2025
|
|
||
| For the bulk of the Playwright testing within the react webviews, we test the functionality by comparing screenshots of the expected results to the current test state. | ||
|
|
||
| We can't use playwright's builtin locator functions, because VSCode webviews are sandboxed- due to cross-origin restrictions, their HTML content can't be accessed outside the webview context (which unfortunately is where the Playwright test suite is run). |
There was a problem hiding this comment.
Have you looked into https://playwright.dev/docs/api/class-framelocator?
eclipse-theia/theia#14896 (reply in thread) They use iframe tho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up playwright infrastructure for collecting coverage on react webviews and testing react webviews. There's also a few really minor changes to some Execution Plan react components, which just make it easier to playwright test them.
This is also only for local testing.