Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set messages tab active if there is a query execution error #18932

Merged
merged 4 commits into from
Mar 14, 2025
Merged

Conversation

cssuh
Copy link
Member

@cssuh cssuh commented Mar 13, 2025

Before: When you run SELECT 1/0, the empty results pane is shown, instead of the messages tab with the divide by zero error

After: We show the messages tab by default if there is an error with the query execution.

(also sets view to messages tab if the user cancels the query)

Fixes #18702
Fixes #18923

Copy link

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 51.06% 51.19% $${\color{lightgreen} .13\% }$$
VSIX Size 12990 KB 12990 KB $${\color{lightgreen} 0 KB \space (0\%) }$$
Webview Bundle Size 3196 KB 3196 KB $${\color{lightgreen} 0 KB \space (0\%) }$$

@cssuh cssuh requested a review from caohai March 13, 2025 20:08
@cssuh cssuh merged commit 0a523a9 into main Mar 14, 2025
6 checks passed
@cssuh cssuh deleted the chsuh/bugFixes branch March 14, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants