Merge pull request #41552 from Microsoft/rename-workspaceedit-proto

Allow renaming/creating/deleting files in a workspaced edit

extensions/vscode-api-tests/src/workspace.test.ts

@@ -10,6 +10,7 @@ import * as vscode from 'vscode';
 import { createRandomFile, deleteFile, closeAllEditors, pathEquals } from './utils';
 import { join, basename } from 'path';
 import * as fs from 'fs';
+import { Uri } from 'vscode';
 
 suite('workspace-namespace', () => {
 
@@ -505,4 +506,44 @@ suite('workspace-namespace', () => {
 			return vscode.workspace.applyEdit(edit);
 		});
 	});
+
+
+	test('applyEdit should fail when editing deleted resource', async () => {
+		const resource = await createRandomFile();
+
+		const edit = new vscode.WorkspaceEdit();
+		edit.deleteResource(resource);
+		try {
+			edit.insert(resource, new vscode.Position(0, 0), '');
+			assert.fail(false, 'Should disallow edit of deleted resource');
+		} catch {
+			// noop
+		}
+	});
+
+	test('applyEdit should fail when renaming deleted resource', async () => {
+		const resource = await createRandomFile();
+
+		const edit = new vscode.WorkspaceEdit();
+		edit.deleteResource(resource);
+		try {
+			edit.renameResource(resource, resource);
+			assert.fail(false, 'Should disallow rename of deleted resource');
+		} catch {
+			// noop
+		}
+	});
+
+	test('applyEdit should fail when editing renamed from resource', async () => {
+		const resource = await createRandomFile();
+		const newResource = Uri.parse(resource.fsPath + '.1');
+		const edit = new vscode.WorkspaceEdit();
+		edit.renameResource(resource, newResource);
+		try {
+			edit.insert(resource, new vscode.Position(0, 0), '');
+			assert.fail(false, 'Should disallow editing renamed file');
+		} catch {
+			// noop
+		}
+	});
 });