Skip to content

Commit

Permalink
Fix #125506
Browse files Browse the repository at this point in the history
  • Loading branch information
Jackson Kearl committed Jul 29, 2021
1 parent 5c1b0b7 commit 752b6e4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -159,12 +159,12 @@ export const walkthroughsExtensionPoint = ExtensionsRegistry.registerExtensionPo
body: 'onContext:${2:key}'
},
{
label: 'extensionInstalled',
label: 'onExtensionInstalled',
description: localize('walkthroughs.steps.completionEvents.extensionInstalled', 'Check off step when an extension with the given id is installed. If the extension is already installed, the step will start off checked.'),
body: 'extensionInstalled:${3:extensionId}'
},
{
label: 'stepSelected',
label: 'onStepSelected',
description: localize('walkthroughs.steps.completionEvents.stepSelected', 'Check off step as soon as it is selected.'),
body: 'stepSelected'
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -609,14 +609,14 @@ export class GettingStartedService extends Disposable implements IGettingStarted
}
break;
}
case 'stepSelected':
event = eventType + ':' + step.id;
case 'onStepSelected': case 'stepSelected':
event = 'stepSelected:' + step.id;
break;
case 'onCommand':
event = eventType + ':' + argument.replace(/^toSide:/, '');
break;
case 'extensionInstalled':
event = eventType + ':' + argument.toLowerCase();
case 'onExtensionInstalled': case 'extensionInstalled':
event = 'extensionInstalled:' + argument.toLowerCase();
break;
default:
console.error(`Unknown completionEvent ${event} when registering step ${step.id}`);
Expand Down

0 comments on commit 752b6e4

Please sign in to comment.