Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish rename on type #104823

Closed
3 tasks done
aeschli opened this issue Aug 17, 2020 · 1 comment
Closed
3 tasks done

Polish rename on type #104823

aeschli opened this issue Aug 17, 2020 · 1 comment
Assignees
@aeschli
Labels
plan-item VS Code - planned item for upcoming
Milestone
August 2020

Comments

@aeschli
Copy link
Contributor

aeschli commented Aug 17, 2020 •
edited
Loading

@aeschli aeschli self-assigned this Aug 17, 2020
@aeschli aeschli added this to the August 2020 milestone Aug 17, 2020
@aeschli aeschli added the plan-item VS Code - planned item for upcoming label Aug 17, 2020
@kieferrm kieferrm mentioned this issue Aug 17, 2020
Closed
40 tasks
aeschli added a commit that referenced this issue Aug 18, 2020
@aeschli
renameOnType: don't register listeners when feature is disabled or ha…
0c61cd2 
…s no providers (#104823)
aeschli added a commit that referenced this issue Aug 21, 2020
@aeschli
onTypeRename: wordPattern (for #104823)
fae07df
@aeschli
Copy link
Contributor Author

aeschli commented Aug 24, 2020

Based on feedback, the API has been changed to take a word pattern instead of a stop pattern.
When in the rename mode, changes are applied to all ranges only as long as the new symbol name matches the given word pattern.
Word patterns can be provided with the response, or when registering a provider. The response's word pattern takes precedence over the provider word pattern. If no word pattern is provided, the language definition's word definition is used.

The changes are on master.

In order for others to give feedback, the API stays proposed this milestone, and will be made final next milestone.

@aeschli aeschli closed this as completed Aug 24, 2020
@aeschli aeschli mentioned this issue Aug 31, 2020
Closed
2 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
plan-item VS Code - planned item for upcoming
Projects
None yet
Milestone
August 2020
Development

No branches or pull requests
1 participant
@aeschli