Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Hover: Allow keyboard to search through properties #127716

Closed
jasonwilliams opened this issue Jun 30, 2021 · 10 comments
Closed

Debug Hover: Allow keyboard to search through properties #127716

jasonwilliams opened this issue Jun 30, 2021 · 10 comments
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verified Verification succeeded
Milestone

Comments

@jasonwilliams
Copy link
Contributor

When hovering over an object (while the breakpoint is triggered) you can get a list of properties. Sometimes that list is very long. Is it possible to have a similar experience to the Explorer (in the side bar), where typing a letter moves the focus to that property?

For example in the gif below i would expect to type "me" and be taken down to "memoizedProps"
popUp

When the hover has focus the keyboard doesn't change content in the editor anyway so this should be safe to add without changing people's workflow.

@connor4312 connor4312 transferred this issue from microsoft/vscode-js-debug Jun 30, 2021
@connor4312 connor4312 assigned isidorn and unassigned connor4312 Jun 30, 2021
@connor4312 connor4312 added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jun 30, 2021
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Jul 1, 2021
@isidorn isidorn added this to the June 2021 milestone Jul 1, 2021
@isidorn isidorn closed this as completed in 9892154 Jul 1, 2021
@isidorn
Copy link
Contributor

isidorn commented Jul 1, 2021

@jasonwilliams good catch, thanks for opening this issue. Now we support that you can click in the debug hover and type the name of the variables to be navigated to them. This already works in the variables view.

To verify: open debug hover, click on it, start typing the name of the variable from the hover and make sure that variable gets focused

@connor4312
Copy link
Member

connor4312 commented Jul 1, 2021

This is great to see, but I think we might need a little polish here when dealing with filter mode. We should not make the hover smaller when filtering down to a smaller tree, otherwise if your mouse it outside of it this can happen:

@connor4312 connor4312 reopened this Jul 1, 2021
@jasonwilliams
Copy link
Contributor Author

I agree, my expectation would be moving towards the target but keeping the hover window the same size

@isidorn
Copy link
Contributor

isidorn commented Jul 2, 2021

@jasonwilliams yeah that is the default behaviour
@connor4312 we should just disable filtering in the debug hover. I have now done that, and we are only supporting the "simple keyboard navigation" = no filter, focus just jumps based on pressed key. Thanks for finding this.

@isidorn isidorn closed this as completed in 4495b3c Jul 2, 2021
@isidorn isidorn changed the title Allow keyboard to search through properties (within Breakpoint Hover) Debug Hover: Allow keyboard to search through properties Jul 2, 2021
@isidorn isidorn added the on-release-notes Issue/pull request mentioned in release notes label Jul 2, 2021
@jasonwilliams
Copy link
Contributor Author

@isidorn can you go straight to top straight to bottom via the keyboard? (Sorry this may need to be a separate request if not)

@rzhao271
Copy link
Contributor

rzhao271 commented Jul 6, 2021

@jasonwilliams is the rest of the implementation working ok right now?
If so, I think we can set this issue to verified (or z-author-verified), since a new Stable is shipping soon, and we'd like to get various issues verified before then.
Meanwhile, I think you can write #127716 (comment) onto a new feature request, and link it back to this issue.

@rzhao271 rzhao271 added the author-verification-requested Issues potentially verifiable by issue author label Jul 6, 2021
@connor4312 connor4312 added the verified Verification succeeded label Jul 6, 2021
@connor4312
Copy link
Member

I can verify

@jasonwilliams
Copy link
Contributor Author

I won’t be at my machine for a few days so would need to delegate verifying to @connor4312

@isidorn
Copy link
Contributor

isidorn commented Jul 26, 2021

@jasonwilliams yeah, home or cmd + left for first element, end or cmd+right for last element.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@jasonwilliams @isidorn @connor4312 @rzhao271 and others