Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook toolbar resizes when the "Go to running cell" button appears #141486

Closed
kimadeline opened this issue Jan 25, 2022 · 4 comments · Fixed by #151674
Closed

Notebook toolbar resizes when the "Go to running cell" button appears #141486

kimadeline opened this issue Jan 25, 2022 · 4 comments · Fixed by #151674
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@kimadeline
Copy link

kimadeline commented Jan 25, 2022

Testing #141223

  • Set notebook.globalToolbarShowLabel to dynamic
  • Resize the window so that it's just big enough for the labels to appear
  • Run a cell
  • Notice that the labels in the toolbar disappeared

I don't know what the best solution for this would be, if there's any 😔 Since a new icon + label are added to the toolbar when running a cell, this issue is bound to happen for window dimensions that straddle the line between labels being displayed and hidden (and that's not even considering translations).

toolbar_smaller.mp4
@roblourens
Copy link
Member

Basically by design, a shorter label for "Go to Running Cell" would help. Would just "Go To" (with the full label in tooltip) and with the spinning icon be clear? Any other ideas to mitigate it @rebornix

@roblourens roblourens added the info-needed Issue requires more information from poster label Jan 26, 2022
@kimadeline
Copy link
Author

I think the spinning icon is a good enough indicator. Even if we address the issue with "Go To", it might happen in languages with a longer translated label.

@roblourens
Copy link
Member

Are you saying the button shouldn't have a label in the toolbar?

@kimadeline
Copy link
Author

Oh no, I meant to say that the current solution is good enough.

@roblourens roblourens added notebook-polish and removed info-needed Issue requires more information from poster labels Jan 28, 2022
@roblourens roblourens self-assigned this Jan 28, 2022
@roblourens roblourens added this to the February 2022 milestone Jan 28, 2022
@rebornix rebornix modified the milestones: February 2022, March 2022 Feb 23, 2022
@rebornix rebornix removed their assignment Mar 23, 2022
@roblourens roblourens modified the milestones: March 2022, April 2022 Mar 23, 2022
@roblourens roblourens modified the milestones: April 2022, May 2022 Apr 23, 2022
@roblourens roblourens modified the milestones: May 2022, June 2022 Jun 1, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@roblourens @rebornix @greazer @kimadeline @vscodenpa and others